Add Reload(bool ignoreCache) method overload #322
Conversation
| auto cefBrowser = _renderClientAdapter->GetCefBrowser(); | ||
|
|
||
| if (cefBrowser != nullptr) | ||
| { | ||
| cefBrowser->Reload(); | ||
| if(ignoreCache) |
There was a problem hiding this comment.
Here it should be if (ignoreCache) (with space) to match the style of the rest of the file.
|
Apart from these suggestions, a nice change! Will happily merge (or @jornh can even do it if you like) as soon as these things have been resolved. |
Fix code comment - Update Reload function code comment with suggestion in IWpfWebBrowser
|
@perlun Is there anything outstanding on this one? |
|
No, it's good now. @jornh, please merge and add to changelog. Go for your idea of moving it back to the wiki please. TIA. Sent from my iPhone On 16 apr 2014, at 06:27, "amaitland" <notifications@github.commailto:notifications@github.com> wrote: @perlunhttps://github.com/perlun Is there anything outstanding on this one? Reply to this email directly or view it on GitHubhttps://github.com//pull/322#issuecomment-40559403. |
|
Merged now. Thanks! @amaitland :) |
|
Sweet! Thanks |
Add Reload(bool ignoreCache) method overload allowing for force Reload of web pages