Enhancement - Add DevToolsClient #3229
Conversation
|
✅ Build CefSharp 84.4.10-CI3684 completed (commit 94a907cbe8 by @amaitland) |
|
Enums aren't always being correctly specified as the type https://github.com/cefsharp/CefSharp/pull/3229/files#diff-a3bf8720232fac45e8639f5e2269cfd5R50 Also need to decorate the enum values with an attribute to map them correctly. |
|
✅ Build CefSharp 84.4.10-CI3685 completed (commit b426c02cbd by @amaitland) |
|
❌ Build CefSharp 84.4.10-CI3686 failed (commit 9359d86a52 by @amaitland) |
|
❌ Build CefSharp 84.4.10-CI3687 failed (commit d64adeecef by @amaitland) |
amaitland
force-pushed
the
enhancement/devtoolsclient
branch
from
b535976
to
f255de8
Compare
|
❌ Build CefSharp 84.4.10-CI3688 failed (commit 07e3365416 by @amaitland) |
|
❌ Build CefSharp 84.4.10-CI3689 failed (commit 55ab713cca by @amaitland) |
|
❌ Build CefSharp 84.4.10-CI3690 failed (commit 9b2f096163 by @amaitland) |
|
✅ Build CefSharp 84.4.10-CI3691 completed (commit 0e62ba4abe by @amaitland) |
|
❌ Build CefSharp 84.4.10-CI3692 failed (commit 39aabd5c33 by @amaitland) |
|
✅ Build CefSharp 84.4.10-CI3693 completed (commit 65fd17d7f7 by @amaitland) |
|
✅ Build CefSharp 84.4.10-CI3694 completed (commit c8d8612e8f by @amaitland) |
|
I think adding a partial method for each domain method that passes in all parameters to allow for custom validation would be worthwhile. From what I can tell there are parameters that are listed as optional yet they're conditionally optional. Set cookie you need to provide either a domain or a url. |
|
❌ Build CefSharp 84.4.10-CI3701 failed (commit 8962036917 by @amaitland) |
- Add hand written class to get a better sense of how the code should be structured. - Improve exception handling
Not complete yet
- Use internal field and datacontract attributes
Improve xml doc comments
- Add option to capture the SyncContext - Add option to provide custom SyncContext (can just pass in UI SyncContext and all continuations will happen there). - Fix bug in ExecuteDevToolsMethodAsync sending the command twice when exeucted on the CEF UI thread
The problem with developing with the .Net Core project where files are automatically included is you forget to include them in the regular csproj file.
amaitland
force-pushed
the
enhancement/devtoolsclient
branch
from
f3ac0c3
to
24ff703
Compare
|
❌ Build CefSharp 84.4.10-CI3702 failed (commit c39480b095 by @amaitland) |
…hrowExceptionIfBrowserNotInitialized calls Those methods were removed as the GetBrowser call handles the checks for us.
|
❌ Build CefSharp 84.4.10-CI3703 failed (commit 981bc28f1d by @amaitland) |
Add ability to manually add validation logic
Was working when targeting M84, now with M85 it fails. The mapping appears to be correct, will need to investigate further
|
✅ Build CefSharp 85.3.6-CI3706 completed (commit 94441fcdd1 by @amaitland) |
Fixes: #3218
Summary:
Changes: [specify the structures changed]
How Has This Been Tested?
Basic unit tests pass
Types of changes
Checklist: