Changed WPF Example TabControl to ItemsSource + added keyboard shortcuts etc #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ViewModels namespace - move ViewModel and rename to BrowserTabViewModel Move and rename MainView to BrowserTabView
…mized) style. Based on 8bddd30 by amaitland, but slightly tweaked so we make each commit even more minimalistic in nature.
… TabControl in a much more MVVM-oriented fashion than previously.
…on-selected tabs look different (to make it easier to distinguish them from each other).
…wserTabViewModels instead. We could clean this up even further by moving stuff out from MainWindow to a MainView & MainViewModel (to achieve a fully code-behind-free approach), but let’s start with this. :) Similarly, based on @amaitland’s changes, only splitting them more aggressively.
… be minimalistic I guess. ;)
…emented command on WebView instead
…place (in MainWindow)
perlun
added a commit
that referenced
this pull request
Apr 30, 2014
perlun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is basically plagiarizing #343 in my preferred way of doing it:
Feel free to comment and of course suggest changes if you like! 😃 Nonetheless, merging this now, but I still want to make a PR so you can inspect my list of commits (it's basically your code, split into smaller chunks) and see how I prefer things done.