Support for manually specifying command line args via ::OnCommandLineProcessing #365

Timobile · 2014-05-23T15:11:16Z

this is an implementation for Support manually specifying a HTTP proxy etc. via OnBeforeCommandLineProcessing #239
a possible usage has been added to the wpf example project (only sets "user-agent" to "me")

…om within the app and be processed by cef (used OnBeforeCommandLineProcessing for implementation)

Timobile · 2014-05-23T15:17:21Z

CefSharp.Core/Internals/CefSharpApp.h

@@ -13,16 +13,50 @@ namespace CefSharp
    class CefSharpApp : public CefApp
    {
        gcroot<CefSettings^> _cefSettings;
+        gcroot<IDictionary<String^, String^>^> _cefCommandLineArgs;


i am new to c++/cli, did look up gcnew and gcroot but i am unsure if this is right

Timobile · 2014-05-23T15:28:20Z

to add proxy settings you could do this:

var commandLineArgs = new Dictionary<string, string>
{
{"proxy-server", "http=webfilter.mydomain.com:8080" },
{"proxy-bypass-list", ".google.;*.local"}
}

JanEggers · 2014-05-23T18:32:11Z

nicely done i will try that out on monday with our corporate proxy.

i think it would be cleaner if the Dictionary was added as property to the cefsettings.

Timobile · 2014-05-24T12:55:50Z

ok, i will change this as soon as possible.

Timobile · 2014-05-24T13:23:09Z

i think that all/most of the other properties of CefSettings.h are "forwarded" to a native struct/a type wrapper from the cef.sdk. I don't know how i should add command line args there. Or is it enough to stay at the clr side and not forward these to the struct? I think i have to look closer at the code. At the moment i do not understand what is happening there.

JanEggers · 2014-05-24T13:54:13Z

just stay at the clr side at use it where u need it

Timobile · 2014-05-25T21:53:08Z

did update my pr and did incorporate command line args into CefSettings

amaitland · 2014-05-25T23:10:12Z

@Timobile Adding CommandLineArgs to CefSettings looks much cleaner, nice work 👍

amaitland · 2014-05-26T03:13:41Z

Perhaps it's worth posting an updated usage example?

Timobile · 2014-05-27T07:02:32Z

Perhaps it's worth posting an updated usage example?

sure, here it is:

settings.CefCommandLineArgs.Add("user-agent", "me");

right now you can not specify a whole dictionary to be used as CefCommandLineArgs. Should i add a setter for CefCommandLineArgs? Then it would look like above and additionally it would be possible to add many arguments like this:

settings.CefCommandLineArgs = new Dictionary<string, string>
{
    {"user-agent", "me"},
    {"proxy-server", "http=webfilter.mydomain.com:8080" }
};

amaitland · 2014-05-27T07:15:54Z

@Timobile I don't really mind one way or another, so see what other people have as a preference. As it stands it's consistent with cefCustomSchemes.

Timobile · 2014-05-27T07:28:24Z

yes, this was my intention when not adding the setter, but perhaps it is more convenient for the user to be able to use both possibilities? And probably you will add more than one commandLineArg at once. With schemes this is not the case i think (but i did never use them i have to admit).

amaitland · 2014-05-30T06:21:05Z

CefSharp.Core/Internals/CefSharpApp.h

@@ -1,4 +1,4 @@
-// Copyright � 2010-2014 The CefSharp Authors. All rights reserved.
+// Copyright � 2010-2014 The CefSharp Authors. All rights reserved.


Copyright symbol has become garbled, will need to fix at some stage.

@amaitland @perlun I'm thinking we should just replace the ©️ symbol with a (c) at some point even tough they look nice when they are not broken. They seem to break all the time. I think we can use our and others time better on something else. Agree?

Yep, works for me!

It's a shame we still fight the ASCII monster these days... Do you have any clue why it breaks? Is it the GitHub web UI that causes it? I think Visual Studio should be UTF8-safe.

Sent from my iPhone

On 30 maj 2014, at 10:40, "jornh" <notifications@github.com mailto:notifications@github.com> wrote:

In CefSharp.Core/Internals/CefSharpApp.h:

@@ -1,4 +1,4 @@
-// Copyright ? 2010-2014 The CefSharp Authors. All rights reserved.
+// Copyright ? 2010-2014 The CefSharp Authors. All rights reserved.

@amaitlandhttps://github.com/amaitland @perlunhttps://github.com/perlun I'm thinking we should just replace the [:copyright:] symbol with a (c) at some point even tough they look nice when they are not broken. They seem to break all the time. I think we can use our and others time better on something else. Agree?

Reply to this email directly or view it on GitHubhttps://github.com//pull/365/files#r13219264.

amaitland · 2014-05-30T06:23:55Z

I've had a chance to test this one, other than the two minor pedantic things I'm happy to see this one merged 😄

@jornh Anything else you'd like to see before merging this one? I don't manually fixing up this two minor issues
@Timobile Thanks for the great work on this one!

jornh · 2014-05-30T07:52:42Z

No I think it's good! Please go ahead and do the merge.

@Timobile a VERY well done and useful first contribution 😄 Happy to see more from your side, Vielen Dank!

Support for manually specifying command line args via ::OnCommandLineProcessing

amaitland · 2014-05-30T08:07:37Z

@jornh I've fixed those two small things on master so I think we can happily move on to the next PR 😄

amaitland · 2014-05-30T08:19:01Z

When I think about it, we probably don't want to set "user-agent" to "me" in either of the examples, so I've commented that out and added a comment to serve as a usage example for the short term.
1415075

jornh · 2014-05-30T09:11:07Z

Good minor tweaks, @amaitland remember to close #239 (for people who listen to that one) with a reference to this PR and add a line to the ChangeLog (for everyone) - if you didn't already.

Timobile · 2014-06-02T21:17:17Z

wow, cool, this got merged!
sorry that i did not show up last days - i just became father 2nd time and so life is flying by without ever looking at my emails.

The thing with the garbled copyright could realy been done by the web frontend at github. Changed something there and after that the update/push became 'difficult'. I think i did overlook this problem.

@jornh thanks for the encouragement, Gern' geschehen :-)
@amaitland the usage example was not very elaborated i guess. Did just throw in my test example which can easily be verified when looking at the data sent out. I think it's better the way you corrected it. Thanks.

jornh · 2014-06-02T22:25:24Z

No worries, family expansions always comes higher in on the list than Pull Request in CefSharp-land.

Big congrats on the new 🚼

amaitland · 2014-06-03T00:35:52Z

@Timobile Congrats on the new 🚼

Thanks again for the contribution!

kropewnicki · 2014-06-09T17:45:06Z

@Timobile if i wanted to pass in a named proxy using your settings, how would I do it?

for example if my network proxy is
from
https://code.google.com/p/chromiumembedded/wiki/GeneralUsage
command line switch is
--proxy-server="foopy:99"
I was thinking the the arg would be
string proxy = "="foopy:8080"";
settings.CefCommandLineArgs.Add("--proxy-server",proxy);

but it does not work the way i expect.

jornh · 2014-06-09T18:19:11Z

Try skipping the -- and also the = see #365 (comment) for a few examples.

Timobile · 2014-06-09T21:13:39Z

@kropewnicki: yes, @jornh should be right. My Example above is

settings.CefCommandLineArgs.Add("user-agent", "me");

In your case try

settings.CefCommandLineArgs.Add("proxy-server", "foopy:99"); // this is for http and https

or

settings.CefCommandLineArgs.Add("proxy-server", "http=foopy:99"); // this is only for http

but be aware that my experience with handling of an (ntlm) authenticating proxy in the current version is that it does not work. Maybe it works if no ntlm authentication is required. I wrote some lines about it here #239 . If you get this working somehow, please leave a comment here or in #239 so i can try it with my setup too.

oxbough · 2014-06-10T16:59:55Z

I am back to working on a CEFsharp solution for my project; Thanks for adding this feature. I still get an exception when running in VS2010 debugger that stops me from running/testing/debugging the app that way. Maybe not related to this??? I thought it was. I even tried attaching the VS debugger to the app, and it ran fine until attaching the debugger. Same exception. (An event was unable to invoke any of the subscribers. Error Number 0x80040201)

oxbough · 2014-06-10T17:15:55Z

Looks like the issue I'm seeing is related to this ... https://connect.microsoft.com/VisualStudio/feedback/details/538649/system-runtime-interopservices-co

oxbough · 2014-06-10T18:08:51Z

OK. Found the solution for my issue. Found this info posted in 2010 about VS2010 ...
I had "break when exceptions cross AppDomain or managed/native boundaries" set in Option | Debug | General. Clear that flag and the exception stop presenting and you can debug as normally.

perlun · 2014-06-11T01:21:09Z

Another reason why we should perhaps drop VS2010 I guess. 😉 As has been discussed in #381 recently. 😛

Timobile added 3 commits May 23, 2014 16:33

added command line arg handling, so command line args could be set fr…

659f71a

…om within the app and be processed by cef (used OnBeforeCommandLineProcessing for implementation)

Update CefSharpApp.h

fa0b1c4

Update Cef.h

d2a94e0

Timobile reviewed May 23, 2014
View reviewed changes

jornh added this to the 31.0.0 milestone May 23, 2014

migrated cefCommandLineArgs to CefSettings

a942eff

amaitland reviewed May 30, 2014
View reviewed changes

amaitland added a commit that referenced this pull request May 30, 2014

Merge pull request #365 from Timobile/master

10e4233

Support for manually specifying command line args via ::OnCommandLineProcessing

amaitland merged commit 10e4233 into cefsharp:master May 30, 2014

jornh mentioned this pull request May 30, 2014

CefSharp3 crashes shortly after startup in some proxy use cases #309

Closed

amaitland mentioned this pull request May 30, 2014

Support manually specifying a HTTP proxy etc. via OnBeforeCommandLineProcessing #239

Closed

jornh mentioned this pull request Jun 16, 2014

The switches "auth-server-whitelist" and "auth-negotiate-delegate-whitelist" are not working #400

Closed

amaitland mentioned this pull request Jul 14, 2014

Feature Request - Add WPF TouchScroll/Multitouch Support #228

Closed

jornh mentioned this pull request Nov 24, 2014

CefSharp WinForms, Server 2003... runs once, but never again until reboot? #627

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for manually specifying command line args via ::OnCommandLineProcessing #365

Support for manually specifying command line args via ::OnCommandLineProcessing #365

Timobile commented May 23, 2014

Timobile May 23, 2014

Timobile commented May 23, 2014

JanEggers commented May 23, 2014

Timobile commented May 24, 2014

Timobile commented May 24, 2014

JanEggers commented May 24, 2014

Timobile commented May 25, 2014

amaitland commented May 25, 2014

amaitland commented May 26, 2014

Timobile commented May 27, 2014

amaitland commented May 27, 2014

Timobile commented May 27, 2014

amaitland May 30, 2014

jornh May 30, 2014

amaitland May 30, 2014

perlun May 30, 2014

amaitland commented May 30, 2014

jornh commented May 30, 2014

amaitland commented May 30, 2014

amaitland commented May 30, 2014

jornh commented May 30, 2014

Timobile commented Jun 2, 2014

jornh commented Jun 2, 2014

amaitland commented Jun 3, 2014

kropewnicki commented Jun 9, 2014

jornh commented Jun 9, 2014

Timobile commented Jun 9, 2014

oxbough commented Jun 10, 2014

oxbough commented Jun 10, 2014

oxbough commented Jun 10, 2014

perlun commented Jun 11, 2014

		@@ -1,4 +1,4 @@
		// Copyright � 2010-2014 The CefSharp Authors. All rights reserved.
		// Copyright � 2010-2014 The CefSharp Authors. All rights reserved.

Support for manually specifying command line args via ::OnCommandLineProcessing #365

Support for manually specifying command line args via ::OnCommandLineProcessing #365

Conversation

Timobile commented May 23, 2014

Timobile May 23, 2014

Choose a reason for hiding this comment

Timobile commented May 23, 2014

JanEggers commented May 23, 2014

Timobile commented May 24, 2014

Timobile commented May 24, 2014

JanEggers commented May 24, 2014

Timobile commented May 25, 2014

amaitland commented May 25, 2014

amaitland commented May 26, 2014

Timobile commented May 27, 2014

amaitland commented May 27, 2014

Timobile commented May 27, 2014

amaitland May 30, 2014

Choose a reason for hiding this comment

jornh May 30, 2014

Choose a reason for hiding this comment

amaitland May 30, 2014

Choose a reason for hiding this comment

perlun May 30, 2014

Choose a reason for hiding this comment

amaitland commented May 30, 2014

jornh commented May 30, 2014

amaitland commented May 30, 2014

amaitland commented May 30, 2014

jornh commented May 30, 2014

Timobile commented Jun 2, 2014

jornh commented Jun 2, 2014

amaitland commented Jun 3, 2014

kropewnicki commented Jun 9, 2014

jornh commented Jun 9, 2014

Timobile commented Jun 9, 2014

oxbough commented Jun 10, 2014

oxbough commented Jun 10, 2014

oxbough commented Jun 10, 2014

perlun commented Jun 11, 2014