Add OnPluginCrashed to RequestHandler

[amaitland]

Implement IRequestHandler to be notified when a plugin crashes.

[amaitland]

@jornh @JanEggers Any thoughts on how to test this?

[jornh]

I guess one way is to have flash installed, navigate to a page with flash content, manually kill flash in task manager.

Don't know if there are other cases to cover ...

[jornh]

How about adding an extra commit here with a minimal demo of this to the IRequestHandler example s somewhat similar to the OnBeforePlugin one? Just so that we have a place to add a breakpoint for testing ...

[jornh]

Duh - never mind that last comment below on this PR. It's here already 😄

[perlun]

Yes. But it would be good to replace that empty line with a comment there saying "here you could do fun stuff when a plugin crashes" (or perhaps something more useful...). I hate empty lines. 😄

[amaitland]

I think we need something here, a comment, a MessageBox, something else....I'm just unclear on what adds the most value. Perhaps keep it simple and just add a comment 😄

[amaitland]

I found that the handler is triggered when I kill BrowserSubProcess.exe when a flash video is playing, so I think it basically works. Other than displaying a message to users, I've got no idea what else you can do on plugin crash.

Happy to add extra comments if you have any suggestions. I've added you as a contributor to my CefSharp repository, so anything trivial that you feel like fixing up, your more than welcome, I'm not precious about it in any way shape or form!

[perlun]

I've added you as a contributor to my CefSharp repository, so anything trivial that you feel like fixing up, your more than welcome,

Could you add me also? It's so convenient to be able to quick-edit PR:s straight in the GitHub web UI (which requires this access to be set up).

[amaitland]

Done

[amaitland]

For reference I've added you too @JanEggers, figured as we don't have a WIP/DEV branch (perhaps that's something to consider after we get the first stable CefSharp3 out the door?) then it's probably easier when doing code reviews to just fix trivial things up as we go.

[amaitland]

If I add a comment as per @jornh's recommendation does anyone have an objection to merging this one?

[jornh]

I didn't get around to testing it but just committed the comment. Merge away! Sleep time (1.24 here now)

[jornh]

Merging now @amaitland - thanks!
Tested by killing the appropriate BrowserSubProcess.exe and the handler is called. And there was much rejoicing

[amaitland]

Thanks @jornh! Much appreciated!