WPF - Support ALT(Left) and ALT GR (Right) Key.

[spinalcord]

Fixes:

Summary:

• Support ALT(Left) and ALT GR (Right) Key.
• This allows: CTRL+ ALT +[SPECIFIC KEY] to input symbols with WPF (e.g. German keyboard layout)

Changes:

• Extended a if condition (here) to proof whether the ALT key is pressed and not only ALT GR.

How Has This Been Tested?

• Tested with a vanilla project and also with the Cef example browser, which is inside the master src.
• Entered symbols ² ³ { [ ] } } \ @ on certain search engines within Cef example browser

Screenshots (if appropriate):
(Layout: German)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Updated documentation

Checklist:

• Tested the code(if applicable)
• Commented my code
• Changed the documentation(if applicable)
• New files have a license disclaimer
• The formatting is consistent with the project (project supports .editorconfig)

[AppVeyorBot]

✅ Build CefSharp 92.0.260-RCI4162 completed (commit 2942e73e07 by @spinalcord)

[amaitland]

Thanks, in future please target pull requests against master branch. Also please update the pull request title, Update CefBrowserHostWrapper.cpp doesn't describe the change.

Do we need a left and right alt check or can we switch to VK_MENU?

@campersau Thoughts/comments? I know you recently made a refinement to alt gr support.

[campersau]

1️⃣ AltGr+[Key] was working before.

2️⃣ AltGr+Shift+[Key] was fixed by #3627 (I just ported it back to cef)

3️⃣ (L|R)Strg+Alt+[Key] and (L|R)Strg+Alt+Shift+[Key] will be fixed by this PR, which I have confirmed locally as well.

So all of these combinations are now working in WPF when using a german keyboard layout:

Key	(L|R)Strg+Alt+[Key]	(L|R)Strg+Alt+Shift+[Key]	AltGr+[Key]	AltGr+Shift+[Key]
q	@ 3️⃣		@ 1️⃣
e	€ 3️⃣		€ 1️⃣
m	µ 3️⃣		µ 1️⃣
2	² 3️⃣		² 1️⃣
3	³ 3️⃣		³ 1️⃣
7	{ 3️⃣		{ 1️⃣
8	[ 3️⃣		[ 1️⃣
9	] 3️⃣		] 1️⃣
0	} 3️⃣		} 1️⃣
+	~ 3️⃣		~ 1️⃣
<	| 3️⃣		| 1️⃣
ß	\ 3️⃣	ẞ 3️⃣	\ 1️⃣	ẞ 2️⃣

Instead of checking for both VK_LMENU and VK_RMENU checking only for VK_MENU also worked in my tests.

This PR could then also be backported: https://bitbucket.org/chromiumembedded/cef/src/cfdec92624a82fa59119e0aeb2d4744978f0c9c8/tests/cefclient/browser/osr_window_win.cc#lines-796

@spinalcord FYI the screencapture shows WinForms browser instead of WPF.

[spinalcord]

I updated the screenshot.

[amaitland]

Instead of checking for both VK_LMENU and VK_RMENU checking only for VK_MENU also worked in my tests.

@campersau Thanks, sounds like we can simply check for VK_MENU

This PR could then also be backported: https://bitbucket.org/chromiumembedded/cef/src/cfdec92624a82fa59119e0aeb2d4744978f0c9c8/tests/cefclient/browser/osr_window_win.cc#lines-796

Can you clarify what you are referring to? The CefSharp code is structured slightly differently and the IsKeyDown check only happens for KEYEVENT_CHAR currently.

[campersau]

@amaitland I think they are logical equal because of the lines above this. The main difference is that our call to set the event.modifiers comes earlier and thus we can put all the special handling inside the same else (keyEvent.type = KEYEVENT_CHAR) path whereas cef needs another check for event.type == KEYEVENT_CHAR because the event.modifiers are set later.
https://bitbucket.org/chromiumembedded/cef/src/cfdec92624a82fa59119e0aeb2d4744978f0c9c8/tests/cefclient/browser/osr_window_win.cc#lines-786:796

[amaitland]

Merged into master in commit b86aa00

Switched to using VK_MENU in commit e00b1ce

Assigning this to the 93 milestone.

Looking at the Chromium source and I think it might be worth looking at implementing a simplified version of PlatformKeyMap::UsesAltGraph so the code path is only run for supported keyboard layouts.