Rename WebView to ChromiumWebBrowser #384
Conversation
…ile ago when doing mass updates to the file headers. Also, refer to CefSharp.Core now, since that's where the reference comes from.
…System.Windows.Forms.WebBrowser is named. (and our browser control is arguably very similar in nature to the Microsoft ones)
… file also (even though it didn't exist back in 2010).
…s.WebBrowser is actually named.
…every single command description with "Command which"... :)
…rename-webview Conflicts: CefSharp.WinForms.Example/BrowserForm.cs (manually merged)
|
Oops the tests broke https://ci.appveyor.com/project/cefsharp/cefsharp/build/1.0.58/job/262rc6kf4veaei7c#L2885 😛 |
|
I personally prefer the name |
|
I've found one thing I like about the rename: It will be easier to see if people are on CefSharp 1 or 3 if they post an example/problem but forget to specify what they have - so 👍 and "turn up the angst" 😈 One question: Should we start to collect "breaking changes" e.g. on https://github.com/cefsharp/CefSharp/wiki/Versions? |
|
i dont care if names change resharper will fix that for me |
Yes, sounds like a good idea. It seems like people are OK with this change (especially after you fixed the test I broke :wink; I was on an airplane so NuGet package restore didn't work, so I unloaded the tests project...), so feel free to merge and update ChangeLog etc. |
|
Merging now! |
Rename WebView to ChromiumWebBrowser
This is basically what has been discussed elsewhere. I chose the name
ChromiumWebBrowser, which I feel is quite much in line with the standard WinForms/WPFWebBrowsercontrol naming.For the sake of democracy, I didn't do this straight on master, so you have a chance to say 👍 or 👎. 😃
I also made some other minor changes while I was at it, but each one is in a separate commit (like we prescribe for others).