Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevToolsUrl Property #440

Merged
merged 3 commits into from Aug 22, 2014

Conversation

amaitland
Copy link
Member

Add DevToolsUrl property for temporary use until upgrade to Cef 1738

@amaitland amaitland added the cef3 label Aug 5, 2014
@amaitland amaitland added this to the 31.0.0 milestone Aug 5, 2014
@amaitland
Copy link
Member Author

@jornh What do you think about exposing DevToolsUrl in general? Seems it's important to some people to view source. Or do you think we'd be better to wait for more hands on deck, and migrate to 1750 before the first official CefSharp3 release?

@numbersint
Copy link

My 2 cents: I exposed DevToolsUrl on my fork because it is very important to me. I load it in a separate form to debug my main CefSharp form. We are using CefSharp as our main application GUI, with HTML controls, dialogs, etc. The HTML inspector and JavaScript debugger is essential when you do all your web dev in Visual Studio and rely on in-memory AJAX protocol - because you can't debug this in a normal browser.

@amaitland
Copy link
Member Author

@jornh I've updated the comment with version number 1750 and merged in master. Any objections to merging this?

@jornh
Copy link
Contributor

jornh commented Aug 22, 2014

Great, please go ahead and merge!

Sorry about the very little response on my end ATM. Currently kicking off a
new exiting project at work. I must admit when I get home these days not
much energy left for looking at a screen.

On Thursday, August 21, 2014, Alex Maitland notifications@github.com
wrote:

@jornh https://github.com/jornh I've updated the comment with version
number 1750 and merged in master. Any objections to merging this?


Reply to this email directly or view it on GitHub
#440 (comment).

@amaitland
Copy link
Member Author

@jornh No problems, totally understand, I'm sure we've all been there!

amaitland added a commit that referenced this pull request Aug 22, 2014
@amaitland amaitland merged commit 12ba4e8 into cefsharp:master Aug 22, 2014
@amaitland amaitland deleted the feature/add-devtoolsurl branch August 22, 2014 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants