WPF - Ensure only single drag operation is emit on DragSourceEndedAt #4814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4801
Summary:
none
,move
,copy
, orlink
can be passed the the browser host to signify a DragEnd event. Specifying multiple flags on the bitmask seems to prevent the event from firing, and therefore the result that is returned from DragDrop.DoDragDrop is compared to the last drag drop effect we have on record.none
,move
,copy
, orlink
flags by themselves in the bitmask, and seemed to correlate with the event'sdataTransfer.dropEvent
field. Given the API specifies that can only be one of those four values (and not a mixture of them), that seemed reasonable. Furthermore, it seemed that theDoDragDrop
function used within theStartDragging
function would consistently return the mask with more than one value set.Changes:
How Has This Been Tested?
This has been tested by going through the same process detailed in the issue here. This was done on Windows 11, with an x64 architecture, .NET Version 4.7.2, and the WPF implementation.
Types of changes
Checklist: