-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cef.sdk
package to 3.2062.1876-pre1 with VS2013 specific libs too
#532
Conversation
@@ -5,7 +5,7 @@ param( | |||
[Parameter(Position = 1)] | |||
[string] $Version = "37.0.0", | |||
[Parameter(Position = 2)] | |||
[string] $RedistVersion = "3.2062.1856" | |||
[string] $RedistVersion = "3.2062.1876" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this include the -pre
tag? I can't remember
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it depends on when we push CefSharp.*
packages?
If we wait until we have verified the cef.*
ones via use here in the CefSharp repo and pushed them to NuGet proper as non-pre I think we can leave it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verifying the cef.*
packages does make a lot of sense, no point creating extra work for ourselves 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, "measure twice, cut once" and if we can find a way to get what little community CefSharp has help do some of the verification by kicking tires on -pre
NuGet packages etc. I think we should be able to speed up a bit without sacrificing stability.
OK to merge this PR then?
update AppVeyor seems happy about it - which should say it at the least still can build on VS2012 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge this PR then?
Merge away 😄
What about having a
Normalising sounds like an excellent idea 👍
How would an
Keep the brain dumps coming 😄 |
Oh yeah, that's the fourth scenario, here we go with some more brain dumping:
|
Bump `cef.sdk` package to 3.2062.1876-pre1 with VS2013 specific libs too
BTW I guess we have to exercise "the split" on x86/x64 a bit on this branch with how it affects NuGet users (and prepare some communication?). We can use
CefSharp.MinimalExample
+ start from scratch scenarios like the one painfully documented in #520 for that.Maybe we can even move
CefSharp.*
packages a bit more towards a more normal NuGet structure withlib
folders and such? We just need to find a way to make sure we can still install bothx86
andx64
in parallel - or should we go for aAnyCPU
package?Hmm - forgive me for thinking out loud above - I hope some of it brings us forward though ;)