Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change c++ file copyright symbol (©) encoding to work on non-english system #731

Merged
merged 3 commits into from Jan 15, 2015

Conversation

binsys
Copy link
Contributor

@binsys binsys commented Jan 7, 2015

change c++ file copyright symbol (©) encoding from 0xa9(cp1252) to 0xc2 0xa9(cp65001 with bom) ,
now work on non-english system.
Note:* .cs files encoded correct, do not need changes.

…p65001 without bom) ,

now work on non-english system().
@amaitland
Copy link
Member

Should they be with or without BOM? I think the default for c# is with signature.

@amaitland amaitland added this to the 37.0.1 milestone Jan 8, 2015
@binsys
Copy link
Contributor Author

binsys commented Jan 9, 2015

@amaitland Yes, you are right, I missing the BOM.sorry.

…2 0xa9(cp65001 without bom) ,"

This reverts commit defd040.
…p65001 with bom) ,

now work on non-english system().
@amaitland
Copy link
Member

Thanks 👍 I'll try to merge this next week

@amaitland
Copy link
Member

@binsys Merging this now. I've looked at a random sample and everything looks ok 👍

It maybe a little bit of an uphill battle as it's likely new files added will be cp1252 encoded, guess we'll see how we go.

amaitland added a commit that referenced this pull request Jan 15, 2015
change c++ file copyright symbol (©) encoding to work on non-english system
@amaitland amaitland merged commit d95c006 into cefsharp:master Jan 15, 2015
@jornh
Copy link
Contributor

jornh commented Jan 15, 2015

It maybe a little bit of an uphill battle as it's likely new files added will be cp1252 encoded, guess we'll see how we go.

Maybe it can be added as some kind of a linting step to the build, together with spaces vs tabs? Let's see how much of a stumbling block it will be?

@amaitland
Copy link
Member

Maybe it can be added as some kind of a linting step to the build, together with spaces vs tabs? Let's see how much of a stumbling block it will be?

Some sort of pre-commit hook that does some housekeeping would be handy 👍

@binsys binsys deleted the cpp_files_encoding branch January 15, 2015 06:25
@binsys
Copy link
Contributor Author

binsys commented Jan 15, 2015

@amaitland
I recommend replacing © to (C) or Copyright , remove any special encoding characters.

@amaitland
Copy link
Member

@binsys How much of a problem does the Copyright symbol cause when using a non-english system?

Also were you looking to add the plugin functions?

@amaitland amaitland modified the milestones: 37.0.1, 39.0.0 Jan 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants