Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEF now requires Visual Studio 2019 #96

Closed
amaitland opened this issue Jun 23, 2021 · 3 comments
Closed

CEF now requires Visual Studio 2019 #96

amaitland opened this issue Jun 23, 2021 · 3 comments

Comments

@amaitland
Copy link
Member

Issue https://bitbucket.org/chromiumembedded/cef/issues/3140/update-include-base-for-c-11-14-features will bring changes that will likely drop support for compiling the wrapper with older VS versions, this may force us to upgrade to VS2019.
@amaitland
Copy link
Member Author

More details https://groups.google.com/g/cef-announce/c/IMgnaeWipwc/m/so6nGWgWBgAJ

@amaitland amaitland changed the title Visual Studio 2019 maybe required CEF now requires Visual Studio 2019 Jun 23, 2021
amaitland added a commit that referenced this issue Jul 30, 2021
@amaitland
Upgrade to M93 (VS2019 now required)
3e9388a 
- CEF now requires VS2019 to build
- Remove older targets
- Add speculative support for VS2022 (not tested)

Resolves #96
amaitland added a commit that referenced this issue Jul 30, 2021
@amaitland
Upgrade to CEF M93 (VS2019 now required)
436b14a 
- Changes the default to build with VS2019
- Support for older versions will need to be removed.

Issue #96
@amaitland
Copy link
Member Author

Build failed https://ci.appveyor.com/project/cefsharp/cef-binary-5r1rw/builds/40187111

The old version of CMake doesn't support VS2019 (#70)

Will need to look at upgrading to the latest cmake and resolving the AppVeyor specific build issue.

amaitland added a commit that referenced this issue Jul 30, 2021
@amaitland
Appveyor - use cmake installed by default (3.20.2)
7a35311 
Version 3.11.4 doesn't support VS2019
It's possible this will still fail (issue #70)

Issue #96
@amaitland
Copy link
Member Author

Issue #70 should now be resolved. The first VS2019 successful build is https://ci.appveyor.com/project/cefsharp/cef-binary/builds/40187622

amaitland added a commit that referenced this issue Sep 3, 2021
@amaitland
Upgrade to CEF M93 (VS2019 now required)
1fcfa77 
- Changes the default to build with VS2019
- Support for older versions will need to be removed.

Issue #96
amaitland added a commit that referenced this issue Sep 3, 2021
@amaitland
Appveyor - use cmake installed by default (3.20.2)
237989a 
Version 3.11.4 doesn't support VS2019
It's possible this will still fail (issue #70)

Issue #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amaitland