Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added searchfor group matching, chalking and can be applied to actions individually #64

Merged
merged 3 commits into from
Apr 3, 2022
Merged

Added searchfor group matching, chalking and can be applied to actions individually #64

merged 3 commits into from
Apr 3, 2022

Conversation

LauJosefsen
Copy link
Contributor

@LauJosefsen LauJosefsen commented Apr 3, 2022 •
edited
Loading

Closes #63

  • Implement new feature
  • Fix old tests
  • Add tests for new feature

@LauJosefsen LauJosefsen changed the title Added searchfor group matching, chalking and can be applied to action… Draft Added searchfor group matching, chalking and can be applied to actions individually Apr 3, 2022
@LauJosefsen LauJosefsen changed the title Draft Added searchfor group matching, chalking and can be applied to actions individually Added searchfor group matching, chalking and can be applied to actions individually Apr 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.0% 87.0% Coverage
0.0% 0.0% Duplication

@LauJosefsen LauJosefsen mentioned this pull request Apr 3, 2022
Closed
firecow
firecow approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firecow firecow merged commit ece581f into main Apr 3, 2022
@firecow firecow deleted the add-stdout-passthrough branch April 3, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firecow firecow firecow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More featureful searchFor hints and action specific searchFor hints
2 participants
@LauJosefsen @firecow