Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Errors from async calls to Firebase #241

Closed
CarsonHerness opened this issue Jan 15, 2021 · 2 comments · Fixed by #684
Closed

Uncaught Errors from async calls to Firebase #241

CarsonHerness opened this issue Jan 15, 2021 · 2 comments · Fixed by #684
Assignees
Labels
bug Something isn't working

Comments

@CarsonHerness
Copy link
Member

Chrome Dev Tools is showing "Uncaught exception" for async calls to Firebase in the front-end code, even though the errors are caught and being handled. This is likely related to how promises are handled, but it is not clear why the current implementation is not working. It could be because the error is being thrown in another call stack, per this documentation.

Converting the async/await in try/catch statements to then/catch statements seems to fix the issue.

@CarsonHerness CarsonHerness added the bug Something isn't working label Jan 15, 2021
@acgrobman
Copy link
Collaborator

Is this the thing you fixed in recent PR #544?

@CarsonHerness
Copy link
Member Author

Yes but I didn't check the entire front end for try/catch statements so I will re-check and close during bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants