Skip to content
This repository has been archived by the owner on Jun 18, 2023. It is now read-only.

CCDCesque: None as test_indices is parsed incorrectly #73

Closed
ceholden opened this issue Dec 9, 2015 · 0 comments
Closed

CCDCesque: None as test_indices is parsed incorrectly #73

ceholden opened this issue Dec 9, 2015 · 0 comments
Labels
Milestone

Comments

@ceholden
Copy link
Owner

ceholden commented Dec 9, 2015

If user doesn't override test_indices keyword argument, then CCDCesque should use all bands input to fit. There is a logical error in the parsing because self.test_indices is parsed using np.asarray so self.test_indices is None is always False.

if self.test_indices is None:
    self.test_indices = np.arange(self.n_series)

should be

if not np.any(np.asarray(self.test_indices)):
    self.test_indices = np.arange(self.n_series)
@ceholden ceholden added the bug label Dec 9, 2015
@ceholden ceholden added this to the v0.6.0 milestone Dec 9, 2015
ceholden added a commit that referenced this issue Dec 9, 2015
@ceholden ceholden closed this as completed Dec 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant