Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type-safe enum for baud rate computation #1

Closed
wants to merge 2 commits into from
Closed

Use type-safe enum for baud rate computation #1

wants to merge 2 commits into from

Conversation

Sh3Rm4n
Copy link

@Sh3Rm4n Sh3Rm4n commented May 6, 2020

No description provided.

@Sh3Rm4n
Copy link
Author

Sh3Rm4n commented May 6, 2020

Here is the implementation how I would use the type-safe enumerated value instead of magic bit values, regarding stm32-rs#98

ceigel
ceigel reviewed May 13, 2020
View reviewed changes
Copy link
Owner

@ceigel ceigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind if I refuse this PR. I saw it after I implemented the same thing.

@ceigel ceigel closed this May 13, 2020
@Sh3Rm4n Sh3Rm4n deleted the ceigel-master branch November 28, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceigel ceigel ceigel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Sh3Rm4n @ceigel