Fix support in plain artifacts handling for OSBS #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the artifact is a plain artifact and it does not exists in Brew, OSBS builds is failing. It was fixed by falling back into the regular procedure (check local, remote cache). If this fails, the build fails. If it doesn't, OSBS will use a mix of artifacts: fetched using fetch-artifacts-url.yaml and from lookaside cache. Approriate warnings are added.
goldmann
force-pushed
the
plain-artifacts-fix
branch
from
34281a1
to
907e30e
Compare
|
Merging to build the RPM to test it on CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the artifact is a plain artifact and it does not exists in Brew, OSBS builds is failing.
It was fixed by falling back into the regular procedure (check local, remote cache).
If this fails, the build fails. If it doesn't, OSBS will use a mix of artifacts:
fetched using fetch-artifacts-url.yaml and from lookaside cache. Approriate
warnings are added.