Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON I/O for celer-g4/sim apps #1045

Merged
merged 11 commits into from
Dec 5, 2023
Merged

Improve JSON I/O for celer-g4/sim apps #1045

merged 11 commits into from
Dec 5, 2023

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Dec 2, 2023

  • Write entries that are inapplicable as "null" placeholders
  • Save version and format to output, check input
  • Set default celer-g4 output name to celeritas.out.json

@sethrj sethrj added enhancement New feature or request app Changes targeting application front ends labels Dec 2, 2023
amandalund
amandalund approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @sethrj!

app/celer-sim/RunnerInputIO.json.cc Outdated Show resolved Hide resolved
@sethrj sethrj merged commit d42f872 into celeritas-project:develop Dec 5, 2023
18 of 19 checks passed
@sethrj sethrj deleted the json-utils branch December 5, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandalund amandalund amandalund approved these changes

Assignees
No one assigned
Labels
app Changes targeting application front ends enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethrj @amandalund