Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TrackSortUtils #1047

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Refactor TrackSortUtils #1047

merged 4 commits into from
Dec 5, 2023

Conversation

esseivaju
Copy link
Contributor

Simplify the TrackSortUtils implementation:

  • Extract common behavior to helper functions
  • Remove unecessary template arguments of function template
  • Remove unnecssary streamid in host-only helper functions
  • Add track sorting by particle type on host (missed in Support sorting tracks by particle types #1044)
  • Remove count_tracks_per_action impl

@esseivaju esseivaju added core Software engineering infrastructure minor Minor internal changes or fixes (including CI updates) labels Dec 4, 2023
@esseivaju esseivaju requested a review from sethrj December 4, 2023 22:49
sethrj
sethrj approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification. Just a couple of style comments.

src/celeritas/track/detail/TrackSortUtils.hh Outdated Show resolved Hide resolved
src/celeritas/track/detail/TrackSortUtils.cu Outdated Show resolved Hide resolved
@sethrj sethrj enabled auto-merge (squash) December 5, 2023 18:02
@sethrj sethrj merged commit 2d6d983 into celeritas-project:develop Dec 5, 2023
18 of 19 checks passed
@esseivaju esseivaju deleted the refactor-tracksort branch May 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
core Software engineering infrastructure minor Minor internal changes or fixes (including CI updates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esseivaju @sethrj