Save action times on multi-stream CPU celer-sim #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
pcanal
reviewed
Dec 14, 2023
amandalund
reviewed
Dec 14, 2023
|
I can't reproduce the celer-sim crash locally :( |
|
@amandalund Do you have any idea why this could be segfaulting now? I'm at a loss. |
|
I'll see if I can reproduce it. |
|
Also failed to reproduce on wildstyle/openmp/cuda for debug, release, and reldeb :( |
|
No luck either so far... |
|
Ok, I was able to reproduce it with debug assertions on. In the new transporter accessor in the status: Creating states
status: Celeritas core state initialization complete
status: Warming up
status: Transporting 5 primaries
status: Creating states
status: Creating states
status: Celeritas core state initialization complete
status: Celeritas core state initialization complete
status: Transporting 5 primaries
status: Transporting 5 primaries
/home/alund/celeritas_project/celeritas/app/celer-sim/Transporter.cc:119: error: Exceeded step count of 256: aborting transport loop
/home/alund/celeritas_project/celeritas/app/celer-sim/Transporter.cc:119: error: Exceeded step count of 256: aborting transport loop
/home/alund/celeritas_project/celeritas/app/celer-sim/Transporter.cc:119: error: Exceeded step count of 256: aborting transport loop
/home/alund/celeritas_project/celeritas/app/celer-sim/celer-sim.cc:268: critical: While running input at <stdin>: /home/alund/celeritas_project/celeritas/app/celer-sim/Runner.cc:543:
celeritas: postcondition failed: result
status: Saving output
Failure written to simple-cms-cpu.out.failed.json
fatal: run failed with error 1 |
|
Are there more threads than events in this test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched the regression problems to
"merge_events": falseon CPU, we lost the action-granularity timing results. This restores them. To be consistent with current output, the timing is averaged over the streams.