Rename ORANGE construction files #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
minor
elliottbiondo
approved these changes
Feb 13, 2024
| @@ -21,7 +21,7 @@ | |||
| # include <fstream> | |||
| # include <nlohmann/json.hpp> | |||
|
|
|||
| # include "orange/construct/OrangeInputIO.json.hh" | |||
| # include "orange/OrangeInputIO.json.hh" | |||
There was a problem hiding this comment.
This .cc file doesn't have any info about what version of ORANGE geometries are being updated. Though unrelated to this MR, consider adding a short description.
There was a problem hiding this comment.
Yeah, this just reads in a JSON file (which will translate any "old" parameter names, etc.) and writes it back out again. I'll add a brief in this file, but the app is actually documented in doc/main/usage.rst.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rearranges the ORANGE construction directory, moving the components used for "shape construction" (e.g. the CSG tree) into
orangeinp/, and moving theOrangeInputclass to the main directory. The CSG renaming solves all the weird namespace issues ofusing namespace orange::csg.