Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-precision soft equivalence for plane #1139

Merged
merged 11 commits into from
Mar 5, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Mar 4, 2024

This adds documentation to and fixes the soft equivalence function for planes. Due to the comparisons using $\epsilon^2$, a tolerance of 1e-4f can get washed out in the machine precision error which is larger than 1e-8f.

I have also uninlined LocalSurfaceInserter::operator() to reduce code size.

This also fixes the extra semicolon in ConvexSurfaceBuilder that @stognini reported, and the missing -Werror that allowed that to pass the CI.

@sethrj sethrj added bug Something isn't working orange Work on ORANGE geometry engine labels Mar 4, 2024
@sethrj sethrj enabled auto-merge (squash) March 5, 2024 03:35
@sethrj sethrj merged commit f570558 into celeritas-project:develop Mar 5, 2024
20 of 21 checks passed
@sethrj sethrj deleted the plane-soft-equiv branch March 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working orange Work on ORANGE geometry engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants