Fix single-precision soft equivalence for plane #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation to and fixes the soft equivalence function for planes. Due to the comparisons using$\epsilon^2$ , a tolerance of
1e-4f
can get washed out in the machine precision error which is larger than1e-8f
.I have also uninlined
LocalSurfaceInserter::operator()
to reduce code size.This also fixes the extra semicolon in
ConvexSurfaceBuilder
that @stognini reported, and the missing-Werror
that allowed that to pass the CI.