Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ExplicitActionInterface to support optical data #1160

Merged
merged 6 commits into from Mar 22, 2024

Conversation

pcanal
Copy link
Contributor

@pcanal pcanal commented Mar 21, 2024

ActionSequence::execute is now templated on the Params/State type and cast them to the concrete type.

…re alternative.

ActionSequence::execute is now templated on the Params/State type and cast them to the concrete type.
@pcanal pcanal requested a review from sethrj March 21, 2024 19:54
src/celeritas/global/detail/ActionSequence.cc Show resolved Hide resolved
src/celeritas/global/ActionInterface.hh Outdated Show resolved Hide resolved
src/celeritas/global/detail/ActionSequence.cc Outdated Show resolved Hide resolved
src/celeritas/global/detail/ActionSequence.cc Outdated Show resolved Hide resolved
src/celeritas/global/detail/ActionSequence.cc Outdated Show resolved Hide resolved
src/celeritas/global/detail/ActionSequence.hh Outdated Show resolved Hide resolved
src/celeritas/global/detail/ParamsTraits.hh Outdated Show resolved Hide resolved
@sethrj sethrj added core Software engineering infrastructure minor Minor internal changes or fixes (including CI updates) labels Mar 21, 2024
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sethrj sethrj enabled auto-merge (squash) March 22, 2024 18:52
@sethrj sethrj changed the title Split ExplicitActionInterface in ExplicitCoreActionInterface and future alternative. Split ExplicitActionInterface to support optical data Mar 22, 2024
@sethrj sethrj merged commit 6c2a07a into celeritas-project:develop Mar 22, 2024
25 of 26 checks passed
@sethrj sethrj mentioned this pull request Apr 23, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Software engineering infrastructure minor Minor internal changes or fixes (including CI updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants