Complete ORANGE construction from CSG objects #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
sethrj
force-pushed
the
unit-input-build
branch
from
dcf0819
to
50624d6
Compare
sethrj
force-pushed
the
unit-input-build
branch
from
55dc454
to
afc2c6d
Compare
|
@elliottbiondo Don't worry, most of the "changes" in the diff are new JSON files. |
…onservatie behavior
…n overconservatie behavior
elliottbiondo
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the initial implementation of building surface-based multilevel ORANGE universes from shapes/solids/CSG operations. It transforms the constructed "CSG unit" into an
OrangeInputclasses. I've re-implemented theuniverses.org.omntest and ensured the constructed geometry is the same and that tracking works on it.