Add Windows/Linux no-dependency builds #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwing from a C function with windows: ``` celeritas\src\corecel\sys\ScopedSignalHandler.cc(29): error C2220: the following warning is treated as an error celeritas\src\corecel\sys\ScopedSignalHandler.cc(29): warning C4297: '`anonymous-namespace'::celer_set_signal': function assumed not to throw an exception but does celeritas\src\corecel\sys\ScopedSignalHandler.cc(29): note: The function is extern "C" and /EHc was specified ``` Using `std::fma` in an integer template context: ``` celeritas\src\orange\MatrixUtils.cc(76): error C2220: the following warning is treated as an error celeritas\src\orange\MatrixUtils.cc(76): warning C4244: '=': conversion from 'double' to 'int', possible loss of data ``` Missing include: ``` celeritas\src\orange\orangeinp\detail\PostfixLogicBuilder.cc(215): error C2039: 'sort': is not a member of 'std' ``` Not propagating compile flags to celer-g4 when Geant4 is disabled: ``` ostream(779): error C2220: the following warning is treated as an error ostream(779): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc ``` Accidental use of real_type instead of size_type: ``` celeritas\src\celeritas\optical\detail\../OpticalGenData.hh(150): warning C4244: 'argument': conversion from 'const celeritas::real_type' to 'size_t', possible loss of data ``` Implicit truncation from real_type to size_type: ``` 2024-04-21T11:40:36.2485761Z D:\a\celeritas\celeritas\src\celeritas/optical/ScintillationPreGenerator.hh(120): error C2220: the following warning is treated as an error 2024-04-21T11:40:36.2488477Z D:\a\celeritas\celeritas\src\celeritas/optical/ScintillationPreGenerator.hh(120): warning C4244: '=': conversion from 'T' to 'celeritas::size_type', possible loss of data ```
sethrj
added
documentation
sethrj
commented
Apr 21, 2024
|
Ping @pcanal |
pcanal
reviewed
Apr 24, 2024
pcanal
reviewed
Apr 24, 2024
|
Ideally commit 524fbd4 (and any related addition) would become its own PR as it is distinct in nature (actual code fix) from the rest of the PR (infrastructure/CI extension). |
|
@pcanal Agreed, I can do that. |
pcanal
reviewed
Apr 24, 2024
pcanal
reviewed
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "build with zero dependencies" use case is helpful for trying to get up and running on a completely new experimental system. Adding a Windows build with error checking improves our ability to catch subtle mistakes, and improves downstream compatibility with SCALE (@hartsw ) and other users.
A follow-on request will fix the errors from no-JSON and MSVC.