Improve gentrap documentation and fix typos #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The points in upper face should still be provided in the same corresponding order as in the lower face. Otherwise a standard trapezoid will have twisted faces, which is still not supported for now.
mrguilima
added
bug
sethrj
removed
the
documentation
sethrj
changed the title
sethrj
requested changes
Apr 25, 2024
|
@mrguilima Maybe some additional restrictions are needed on the points input to the gentrap. For example, are there restrictions about the top and bottom points not being rotated 180 degrees? |
|
@mrguilima Actually it looks like the problem is that the normal calculation assumes the points are CCW ... which is not the case. |
This reverts commit d107129.
sethrj
changed the title
sethrj
added
documentation
sethrj
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the input lower points can be ordered in both CW or CCW orderings, the sense needs to take into account the sign of the plane offset with respect to the plane normal.
An extra test was added for opposite ordering of points (CCW ordering), and the documentation has been adjusted.
See review process for descriptions of the labels and requirements.