Add random selector helper class #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by the random Selector
amandalund
approved these changes
Apr 19, 2021
pcanal
reviewed
Apr 20, 2021
Comment on lines
+50
to
+51
| v -= i; | ||
| return v; |
There was a problem hiding this comment.
What is the advantage of the code use over 'just'
return v - i;
since 'v' does not appear to be a reference?
There was a problem hiding this comment.
Requires defining an extra operator for the detail iterator
sethrj
added
physics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a bit over-engineered, but it abstracts the selection of a discrete PDF that's calculated on-the-fly. I'd intended to use it for the ElementSelector, Livermore, and AtomicRelaxation; but the element selector would be ugly (either re-instantiating the Selector at each sample, or requiring ugly templates to make it class data, or rephrasing it to be a function), and the Livermore/Atomic cases allow a "remainder" for the PDFs -- it's OK if they don't add up to one.
Regardless of those absences, I've implemented the selector in PhysicsStepUtils (which makes the code much cleaner) and replaced the awkward construction in the Rayleigh sampler with the simpler Selector. It is slightly less efficient (requiring one more subtraction) but I can't imagine that being a big deal.
For the purpose of testing, I wrote a SequenceEngine that allows us to use an arbitrary "random" number sequence that enables fine-grained testing of random distributions, and could also be used in our Interactor tests to make sure all of the rejection cases behave exactly as expected.