Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orange: add volume definition and JSON I/O for surface/volume #307

Merged
merged 7 commits into from Nov 11, 2021

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Nov 8, 2021

Add volume definitions, sample geometries, and JSON-based I/O implementations for surface and volume reading in ORANGE.

Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @sethrj! Nothing from me :)

src/orange/Data.hh Outdated Show resolved Hide resolved
@sethrj
Copy link
Member Author

sethrj commented Nov 11, 2021

CI failure is another issue with disk space...

@sethrj sethrj merged commit 84b1ce0 into celeritas-project:master Nov 11, 2021
@sethrj sethrj deleted the orange-io branch November 11, 2021 13:59
@sethrj sethrj mentioned this pull request Jan 4, 2022
9 tasks
@sethrj sethrj added orange Work on ORANGE geometry engine enhancement New feature or request and removed geometry labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request orange Work on ORANGE geometry engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants