ORANGE: implement distance-to-boundary calculation #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
paulromano
reviewed
Jan 4, 2022
paulromano
approved these changes
Jan 4, 2022
|
Thanks @paulromano ! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements distance-to-boundary calculations for single universes. There are two algorithms for finding the nearest surface crossing. The first is the "simple" one, where crossing any boundary exits the volume. In that case, the closest nonzero distance points to the target surface. The second "complex" algorithm effectively tracks through the internal surfaces in order (by sorting) until outside the volume. Unlike the CPU implementation of ORANGE in SCALE, this implementation sorts surfaces using an intermediate indirection array of face IDs.
We should consider as an optimization the option of specifying a "maximum" intersection distance, allowing us to reduce the number of surfaces considered in the sort and in the boundary crossing.