New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory diagnostic #716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
New feature or request
core
Software engineering infrastructure
labels
Apr 9, 2023
amandalund
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @sethrj! Looks like the HIP build needs to be fixed, but otherwise looks good to me 🐰🥚
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses system tools to calculate the memory "high watermark" before and after blocks, recording the change in peak across the block (i.e. what's the most new memory allocated) and the high-water marks. The GPU memory may not be as accurate, since it's the reported "free" amount subtracted from the reported "total". Each block records its "parent" block (if applicable) so it will be possible to make a flame graph of memory usage.
simple-cms-cpu.out.json
In the "simple GPU demo loop" above, initializing ROOT takes over half of the total CPU usage. The CPU reporting statistics are more granular on macOS:
macOS CPU demo lookp