Add some quality-of-life CMake defaults #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
core
pcanal
reviewed
Jul 10, 2023
pcanal
reviewed
Jul 10, 2023
pcanal
reviewed
Jul 10, 2023
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
|
CI failures are due to some disk issues on the CI end, not something we have to worry about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some of the main configuration logic a bit and adds a few default cmake variables that @drbenmorgan had added to the VecGeom configuration in the past.
One other small change is that I've removed
BUILD_SHARED_LIBSas a cache variable since it's really a CMake global variable that sets default target properties. Like the other such cmake variables, we set it as a default value (so it affects stuff inside the celeritas dir) but not as a cache value (where it would affect the parent project if Celeritas is being built inside something else).