Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable Celeritas offloading in celer-g4 #860

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Add option to disable Celeritas offloading in celer-g4 #860

merged 2 commits into from
Jul 25, 2023

Conversation

amandalund
Copy link
Contributor

@amandalund amandalund commented Jul 21, 2023 •
edited
Loading

For #850.

I also added an option to use the Celeritas physics list instead of the default FTFP_BERT.

@amandalund amandalund added enhancement New feature or request app Changes targeting application front ends labels Jul 21, 2023
@amandalund amandalund requested a review from sethrj July 21, 2023 00:09
sethrj
sethrj approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but going forward maybe we should move toward using a JSON-based input file for the celer-g4 app?

@sethrj sethrj merged commit cd1c324 into celeritas-project:develop Jul 25, 2023
1 check passed
@amandalund amandalund deleted the g4-celer-disable branch July 25, 2023 16:41
@amandalund
Copy link
Contributor Author

Sure, you mean instead of the macro file?

@amandalund amandalund mentioned this pull request Jul 13, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
app Changes targeting application front ends enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amandalund @sethrj