camqadm error, and fix

[dpwhite2]

On the current master (and I think it at least affects the 2.1.x series as well), using camqadm with yes/no options throws 'too many values to unpack' exceptions.

This recreates the error:

camqadm queue.declare myqueue no yes no no

Using the same command, but without the yes/no options does not raise an exception.

Here is the current contents of the Spec.coerce() method in the celery.bin.camqadm module, followed by my proposed fix:

Current camqadm.py (lines 69-81):

def coerce(self, index, value):
    """Coerce value for argument at index.

    E.g. if :attr:`args` is `[("is_active", bool)]`:

        >>> coerce(0, "False")
        False

    """
    arg_name, arg_type = self.args[index]
    # Might be a custom way to coerce the string value,
    # so look in the coercion map.
    return COERCE.get(arg_type, arg_type)(value)

Here is my suggested fix:

def coerce(self, index, value):
    """Coerce value for argument at index.

    E.g. if :attr:`args` is `[("is_active", bool)]`:

        >>> coerce(0, "False")
        False

    """
    arg_info = self.args[index]
    arg_type = arg_info[1]
    # Might be a custom way to coerce the string value,
    # so look in the coercion map.
    return COERCE.get(arg_type, arg_type)(value)

The fix is only a couple of lines, so I'm hoping posting it here is acceptable instead of doing a full pull request.

Thanks,
David White

[ask]

camqadm: Fixed syntax error when providing options to commands. Closed by 83cde80. Thanks to dpwhite2