Chord counter to use result_expires and is touched #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chord counter keeps track of chord tasks that have finished. This needs to be compatible with result_expires so that if a chord task result is still in cache, chord will be able finish and join (unlock). Otherwise we see that the chord counter has expired while the chord task result still in cache. Incrementing an expired chord counter returns None and comparing that to dependent task number throws an error. Counter's timeout also needs to be refreshed on every chord part return. Memcached backend didn't implement `expire` using client's `touch`, so this is implemented here as well.
|
Thanks Tayfun! Merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chord counter keeps track of chord tasks that have finished. This needs
to be compatible with result_expires so that if a chord task result is
still in cache, chord will be able finish and join (unlock). Otherwise
we see that the chord counter has expired while the chord task result
still in cache. Incrementing an expired chord counter returns None and
comparing that to dependent task number throws an error.
Counter's timeout also needs to be refreshed on every chord part return.
Memcached backend didn't implement
expireusing client'stouch, sothis is implemented here as well.