Celery-v4.2.1, branch master: wrong doc info for tasks_ack_late default value

[meysam81]

Checklist

• I have included the output of celery -A proj report in the issue.
  (if you are not able to do this, then at least specify the Celery
  version affected).
• I have verified that the issue exists against the master branch of Celery.

Steps to reproduce

I have checked my app, the task_acks_late setting is set to False by default, but you are saying in your docs that it's set to True by default.

Expected behavior

I think you should edit the doc for this part

Actual behavior

The actual behavior is that the default global task_acks_late setting is set to False by default

[007]

celery/celery/app/defaults.py

Line 246 in 9b39fc4

acks_late=Option(False, type='bool'),

says it's False by default, and everywhere else it's initialized explicitly says None so this should override.

[huangsam]

Seems like the current docs in master branch says that this is disabled by default:

@thedrow is there still a bug here?

[huangsam]

celery/celery/app/defaults.py

Line 246 in 9b39fc4

acks_late=Option(False, type='bool'),
says it's False by default, and everywhere else it's initialized explicitly says None so this should override.

@007 that is an interesting observation you make. I'm wondering why some values were configured as None instead of the same values as the global defaults in celery/celery/app/defaults.py. @thedrow should the other files initialize the acks_late value as False instead of None?

[thedrow]

They are set to None since if they are None we take the values from the configuration.

[huangsam]

Just checking back here again, but is this issue still valid or can it be closed?

[thedrow]

Master branch looks like it's already updated.