Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0 #6266

Closed
22 of 23 tasks
thedrow opened this issue Jul 30, 2020 · 39 comments
Closed
22 of 23 tasks

Release 5.0 #6266

thedrow opened this issue Jul 30, 2020 · 39 comments

Comments

@thedrow
Copy link
Member

thedrow commented Jul 30, 2020

Version: 5.0
Release PR: #5686

Description

Celery 5.0 is the first major version to drop support for Python 2. It supports Python 3.6+.
This version also drops support for the Riak Result Backend since Riak is unmaintained and does not support modern Python versions.

This version also refactors our CLI to use click as we prepare to make Celery fully async since it allows us
to invoke async functions in response to commands using asyncclick.

Checklist

  • Release PR drafted

  • Kombu Merge Freeze

  • Release Kombu 5.0.0

  • Release Vine 5.0.0

  • Release py-amqp 5.0.0

  • Milestone is 100% done

  • Merge Freeze

  • Release PR reviewed

  • The master branch build passes

    Build Status

  • Release Notes

  • What's New

Process

Alphas

  • Alpha 1
  • Alpha 2

Betas

  • Beta 1

Release Candidates

  • RC 1
  • RC 2
  • RC3

Release Blockers

Potential Release Blockers

@thedrow thedrow added this to the v5.0.0 milestone Jul 30, 2020
@thedrow thedrow self-assigned this Jul 30, 2020
@thedrow thedrow pinned this issue Jul 30, 2020
@auvipy
Copy link
Member

auvipy commented Jul 30, 2020

no Alpha release?

@thedrow
Copy link
Member Author

thedrow commented Jul 30, 2020

🗣️ 📢
Hello everyone.
My name is Omer and I'll be your release manager for this evening.
Please keep both hands and feet inside the ride at all times.
Enjoy:exclamation: :smile:

@thedrow
Copy link
Member Author

thedrow commented Jul 30, 2020

no Alpha release?

We can do one Alpha as well if you'd like.

@thedrow
Copy link
Member Author

thedrow commented Jul 30, 2020

We'll also have to merge freeze Kombu.

@auvipy
Copy link
Member

auvipy commented Jul 31, 2020

i will take care of that open PR in kombu. having an alpha will let everyone know that the API is still unstable and might change little bit before beta.

@thedrow
Copy link
Member Author

thedrow commented Aug 2, 2020

I'm going to release an alpha from the v5-dev branch today.
We're not in the merge freeze stage yet.

@thedrow
Copy link
Member Author

thedrow commented Aug 2, 2020

Getting ready to release the first alpha version of Celery 5.0.

@thedrow
Copy link
Member Author

thedrow commented Aug 2, 2020

Celery 5.0.0a1 was released.
Please test it out and see if you find any functional changes other than the fact that Python 2 support was dropped.

@yuan6785
Copy link

yuan6785 commented Aug 3, 2020

async/await is support?

@thedrow
Copy link
Member Author

thedrow commented Aug 4, 2020

async/await is support?

Not yet. That's in 6.
We'd like to reduce our maintenance burden as much as possible first.

@thedrow
Copy link
Member Author

thedrow commented Aug 4, 2020

Everyone ready for a merge freeze of Kombu? celery/kombu#1232 is ready for merge.

@auvipy
Copy link
Member

auvipy commented Aug 5, 2020

If we create a new maintenance branch for 4.x series, feature freeze in master is ok. Carry-on v5 cycle sir 😁

@yuan6785
Copy link

yuan6785 commented Aug 5, 2020

async/await is support?

Not yet. That's in 6.
We'd like to reduce our maintenance burden as much as possible first.

Great, come on, look forward to the new version

@thedrow
Copy link
Member Author

thedrow commented Aug 5, 2020

Second Alpha coming today.

@thedrow
Copy link
Member Author

thedrow commented Aug 5, 2020

Second alpha released.

I need to get #5718's build to pass and we've got a first beta.
In the meantime, please test the alpha and see if you find anything wrong.

@dduraipandian
Copy link

Is this version support asyncio pool? Or moved to version 6 as in the comment?

Thanks,
Durai Pandian

@thedrow
Copy link
Member Author

thedrow commented Aug 10, 2020

Is this version support asyncio pool? Or moved to version 6 as in the comment?

Thanks,
Durai Pandian

It was moved to version 6.
We decided to reduce scope and advance in small increments to ensure we don't break too many things at once.

@thedrow
Copy link
Member Author

thedrow commented Aug 10, 2020

Right now #5718 is blocking us because we need to figure out how to automatically generate the documentation for the CLI as it was before.
I'm using click-sphinx and I'm nearly there.

@dduraipandian
Copy link

Is this version support asyncio pool? Or moved to version 6 as in the comment?
Thanks,
Durai Pandian

It was moved to version 6.
We decided to reduce scope and advance in small increments to ensure we don't break too many things at once.

Thanks for the reply and thank you for the contribution. Is anyway I can pick that issue and contribute to the project?

@thedrow
Copy link
Member Author

thedrow commented Aug 11, 2020

Of course!

You can always check existing PRs and provide test coverage for them since that's usually missing.
You can also try to debug an issue and provide a bugfix for it.

@thedrow
Copy link
Member Author

thedrow commented Aug 11, 2020

I separated the CLI documentation from the rest of the reference into a dedicated page.
It makes more sense and click-sphinx works better that way.

@tecsunw
Copy link

tecsunw commented Aug 18, 2020

Will couchbase sdk 3.0.0 backend be supported in Celery 5.0?

@auvipy
Copy link
Member

auvipy commented Aug 18, 2020

that should be! gonna milestone that PR #6094

@auvipy
Copy link
Member

auvipy commented Aug 18, 2020

we should check all the necessary driver updates for v5. we should follow Django style release versioning. 5.0, 5.1, 5.2, 5.x each will contain new features and behavioral improvements with no major API removal.

@auvipy
Copy link
Member

auvipy commented Aug 19, 2020

For your kind info, I want to release billiard 4.0a1 before celery 5 rc1 celery/billiard#292 we should wait this month for all the other dependencies got python 3.6+ based new releases IMHO.

@auvipy
Copy link
Member

auvipy commented Aug 19, 2020

will re-evaluate the celery 5 milestones and related dependencies and codes needed to e updated. this weekend.

@thedrow
Copy link
Member Author

thedrow commented Aug 24, 2020

Will couchbase sdk 3.0.0 backend be supported in Celery 5.0?

That's a wonderful idea!

@thedrow
Copy link
Member Author

thedrow commented Sep 1, 2020

RC2 has just been released:exclamation: :tada: :partying_face:
Please try it out and report any problems.

There's going to be at least one more RC before we hit GA.

@clokep
Copy link
Contributor

clokep commented Sep 1, 2020

Would 5.0 be a good time to drop the alternative configuration setting names (see https://docs.celeryproject.org/en/latest/userguide/configuration.html#new-lowercase-settings), they seem to be a source of continual confusion.

@thedrow
Copy link
Member Author

thedrow commented Sep 2, 2020

Would 5.0 be a good time to drop the alternative configuration setting names (see https://docs.celeryproject.org/en/latest/userguide/configuration.html#new-lowercase-settings), they seem to be a source of continual confusion.

I completely agree. Would you mind creating an issue about this and we'll mark it as a blocker.

@clokep
Copy link
Contributor

clokep commented Sep 2, 2020

Would 5.0 be a good time to drop the alternative configuration setting names (see docs.celeryproject.org/en/latest/userguide/configuration.html#new-lowercase-settings), they seem to be a source of continual confusion.

I completely agree. Would you mind creating an issue about this and we'll mark it as a blocker.

See #6327.

@thedrow
Copy link
Member Author

thedrow commented Sep 6, 2020

Please reinstall the latest RC with pip install --update-strategy=eager -U celery.

We've released both amqp 5.0 and vine 5.0.

@maybe-sybr
Copy link
Contributor

maybe-sybr commented Sep 7, 2020

Please reinstall the latest RC with pip install --update-strategy=eager -U celery.

We've released both amqp 5.0 and vine 5.0.

@thedrow - the vine dependency at https://github.com/celery/celery/blob/master/requirements/default.txt#L4 needs to be updated to not conflict with the updated one in amqp. Breakage currently happens on master if you do things with pkg_resources at runtime (I'm installing using a git+https requirement spec).

Edit: Bumping that dependency would also require that we lose celery.five - I'll get a PR together for this since it's causing me some pain at the moment.

@thedrow
Copy link
Member Author

thedrow commented Sep 23, 2020

I've completed the What's New document.
Please review it.

I'm going to hit the release button for GA tomorrow.

@thedrow
Copy link
Member Author

thedrow commented Sep 24, 2020

Hi @celery/core-developers,

We're in merge freeze until 5.0 hits GA.
Thank you.

@thedrow thedrow modified the milestones: 5.0.0, Future Sep 24, 2020
@thedrow
Copy link
Member Author

thedrow commented Sep 24, 2020

I'm waiting for final confirmation from our CI before the final release.

@thedrow
Copy link
Member Author

thedrow commented Sep 24, 2020

Released! 🎉

@Dihfahsih1
Copy link

what is the work around of using celery 5.0 on windows

@thedrow
Copy link
Member Author

thedrow commented Oct 14, 2020

It should work on Windows but we don't actively support that platform.

@thedrow thedrow unpinned this issue Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants