Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization docs #7855

Closed
4 tasks done
sondrelg opened this issue Oct 26, 2022 · 3 comments · Fixed by #7858
Closed
4 tasks done

Update serialization docs #7855

sondrelg opened this issue Oct 26, 2022 · 3 comments · Fixed by #7858

Comments

@sondrelg
Copy link
Contributor

Checklist

  • I have checked the issues list
    for similar or identical bug reports.
  • I have checked the pull requests list
    for existing proposed fixes.
  • I have checked the commit log
    to find out if the bug was already fixed in the master branch.
  • I have included all related issues and possible duplicate issues in this issue
    (If there are none, check this box anyway).

Related Issues and Possible Duplicates

Related Issues

  • None

Possible Duplicates

  • None

Description

The serialization docs include a section on msgpack:

image

Specifically I'm referring to

It’s very young however, and support should be considered experimental at this point.

It seems this sentence was added 12 years back in this commit, which seems to have been around version 2.2.0.

Suggestions

I think it'd be good to revise the docs. I don't think this is accurate any longer. Do you agree? 🙂

@open-collective-bot
Copy link

Hey @sondrelg 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

@sondrelg
Copy link
Contributor Author

I think these should probably also mention that accept_content needs to be expanded for other serialization formats to work. Otherwise you'll see discarded tasks #6953

I'd be happy to create a PR with slight revisions if you agree.

@auvipy
Copy link
Member

auvipy commented Oct 28, 2022

please proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants