Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated concurrency docs page. #8753

Merged
merged 3 commits into from Jan 8, 2024

Conversation

robotrapta
Copy link
Contributor

Description

This is a docs page I wish had existed when I started using celery a couple years ago. The current page seems to imply your only two choices are gevent and eventlet and that led me down a path of unnecessary operational pain.

This page is far from comprehensive, but I don't think it's misleading like the current page is. Also I suspect it's probably a good idea to tell people to stick with prefork unless they have reason not to, especially since other models lack certain features - a fact which AFAICT isn't currently documented at all.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@auvipy auvipy added this to the 5.4 milestone Jan 5, 2024
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition! Thank you very much!
Please review my comment and tag me for any assistance - it would be an impactful effort improving this aspect of the documentation!

docs/userguide/concurrency/index.rst Outdated Show resolved Hide resolved
@robotrapta robotrapta requested a review from Nusnus January 8, 2024 00:40
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a link for the good guide for ref, at least in the PR:
https://celery.school/celery-worker-pools

@Nusnus Nusnus merged commit 1c8e3f9 into celery:main Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants