Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Sphinx from v5.3.0 to v7.x.x #8803

Merged
merged 1 commit into from Jan 18, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Jan 17, 2024

No description provided.

@Nusnus Nusnus self-assigned this Jan 17, 2024
@Nusnus Nusnus added this to the 5.4 milestone Jan 17, 2024
@Nusnus Nusnus marked this pull request as ready for review January 17, 2024 23:57
@Nusnus
Copy link
Member Author

Nusnus commented Jan 18, 2024

Finally!
The “go here” also uses main and not master.
CleanShot 2024-01-18 at 01 59 35@2x
CleanShot 2024-01-18 at 02 00 01@2x

@Nusnus
Copy link
Member Author

Nusnus commented Jan 18, 2024

This also works locally with make -C docs livehtml using latest Sphinx to date.

@Nusnus
Copy link
Member Author

Nusnus commented Jan 18, 2024

Python <3.10 Issue only

ERROR: Could not find a version that satisfies the requirement Sphinx>=7.2.6 (from versions: 0.1.61611, 0.1.61798, 0.1.61843, 0.1.61945, 0.1.61950, 0.2, 0.3, 0.4, 0.4.1, 0.4.2, 0.4.3, 0.5, 0.5.1, 0.5.2b1, 0.5.2, 0.6b1, 0.6, 0.6.1, 0.6.2, 0.6.3, 0.6.4, 0.6.5, 0.6.6, 0.6.7, 1.0b1, 1.0b2, 1.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.1, 1.1.1, 1.1.2, 1.1.3, 1.2b1, 1.2b2, 1.2b3, 1.2, 1.2.1, 1.2.2, 1.2.3, 1.3b1, 1.3b2, 1.3b3, 1.3, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.3.6, 1.4a1, 1.4b1, 1.4, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.5a1, 1.5a2, 1.5b1, 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5, 1.5.6, 1.6b1, 1.6b2, 1.6b3, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.6.6, 1.6.7, 1.7.0b1, 1.7.0b2, 1.7.0, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.7.5, 1.7.6, 1.7.7, 1.7.8, 1.7.9, 1.8.0b1, 1.8.0, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 2.0.0b1, 2.0.0b2, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 3.0.0b1, 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.3.0, 3.3.1, 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.5.0, 3.5.1, 3.5.2, 3.5.3, 3.5.4, 4.0.0b1, 4.0.0b2, 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.1.0, 4.1.1, 4.1.2, 4.2.0, 4.3.0, 4.3.1, 4.3.2, 4.4.0, 4.5.0, 5.0.0b1, 5.0.0, 5.0.1, 5.0.2, 5.1.0, 5.1.1, 5.2.0, 5.2.0.post0, 5.2.1, 5.2.2, 5.2.3, 5.3.0, 6.0.0b1, 6.0.0b2, 6.0.0, 6.0.1, 6.1.0, 6.1.1, 6.1.2, 6.1.3, 6.2.0, 6.2.1, 7.0.0rc1, 7.0.0, 7.0.1, 7.1.0, 7.1.1, 7.1.2)
ERROR: No matching distribution found for Sphinx>=7.2.6

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2576e83) 81.19% compared to head (3c6dec1) 81.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8803   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files         148      148           
  Lines       18523    18523           
  Branches     3165     3165           
=======================================
  Hits        15039    15039           
  Misses       3196     3196           
  Partials      288      288           
Flag Coverage Δ
unittests 81.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus changed the title Upgraded Sphinx from v5.x.x to v7.x.x Upgraded Sphinx from v5.3.0 to v7.x.x Jan 18, 2024
@Nusnus
Copy link
Member Author

Nusnus commented Jan 18, 2024

Ok, seems this error was handled:
CleanShot 2024-01-18 at 02 13 21@2x

@Nusnus Nusnus merged commit d7700e2 into celery:main Jan 18, 2024
82 checks passed
@Nusnus Nusnus deleted the sphinx_upgrade branch January 18, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant