Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support moto 5.0 #8838

Merged
merged 1 commit into from Feb 9, 2024
Merged

Support moto 5.0 #8838

merged 1 commit into from Feb 9, 2024

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

Description

moto 5.0 has been released, and the major change is to pull all of the seperate mock calls into one -- mock_aws. Continue to support moto 4, since it's easy to do so.

moto 5.0 has been released, and the major change is to pull all of the
seperate mock calls into one -- mock_aws. Continue to support moto 4,
since it's easy to do so.
@Nusnus Nusnus self-requested a review February 9, 2024 09:30
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58d2e67) 81.25% compared to head (8ebab3d) 81.25%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8838   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files         149      149           
  Lines       18553    18553           
  Branches     3166     3166           
=======================================
  Hits        15075    15075           
  Misses       3191     3191           
  Partials      287      287           
Flag Coverage Δ
unittests 81.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix - thank you very much!

@Nusnus Nusnus merged commit acae57f into celery:main Feb 9, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants