New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests misusing assertTrue for comparisons fix #612

Merged

auvipy merged 1 commit into celery:master from code-review-doctor:fix-avoid-misusing-assert-true

Feb 16, 2022

Contributor

code-review-doctor commented Feb 15, 2022

Fixes #611


           Fix issue avoid-misusing-assert-true found at https://codereview.doctor

8b4cd2f

auvipy approved these changes

View reviewed changes

auvipy merged commit 4fc6bc9 into celery:master

BioGeek commented Feb 16, 2022

But now you have two identical lines:

https://github.com/code-review-doctor/django-celery/blob/8b4cd2f2cea3db21618e8c29add01229740dd33f/djcelery/tests/test_backends/test_cache.py#L36-L37

I would just delete line 37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment