Skip to content

Commit

Permalink
Use ensure_connection to allow broker failover
Browse files Browse the repository at this point in the history
  • Loading branch information
georgepsarakis committed Apr 26, 2017
1 parent 259ac2e commit 816e3dc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kombu/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ def default_channel(self):
require a channel.
"""
# make sure we're still connected, and if not refresh.
self.connection
self.ensure_connection()
if self._default_channel is None:
self._default_channel = self.channel()
return self._default_channel
Expand Down

4 comments on commit 816e3dc

@gabrielmartin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I think this is the cause of the issue raised for celery: celery/celery#4328

Is this something which could be reverted?

Thanks!

@thedrow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if we revert this, it will regress another bug.

@4383
Copy link

@4383 4383 commented on 816e3dc Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedrow can you refer the "another bug" please?

@thedrow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.