Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl support on redis queue #415

Closed
omerra opened this issue Oct 6, 2014 · 2 comments
Closed

Add ssl support on redis queue #415

omerra opened this issue Oct 6, 2014 · 2 comments

Comments

@omerra
Copy link

omerra commented Oct 6, 2014

Kombu doesn't support redis with SSL connection, this used to make sense because redis on python didn't support this.
However new version of redis-py (2.10+) support easy ssl connection: Redis(ssl=False, ssl_keyfile=None, ssl_certfile=None, ssl_cert_reqs=None, ssl_ca_certs=None, **kwargs)
And there is a new connection class for redis: SSLConnection.
With the way kombu is currently setup, it is possible to search for these ssl params in the options passed, and use SSLConnection instead of normal Connection class

@ghost
Copy link

ghost commented Jul 18, 2015

@ask Do you happen to know if this feature exists in Kombu? Are there plans to implement it?

If there's no action planned, we can probably close this issue.

@ask ask closed this as completed in 3d0528e Oct 23, 2015
ask added a commit to celery/celery that referenced this issue Oct 23, 2015
@ask
Copy link
Contributor

ask commented Oct 23, 2015

@MrTomWhite Pretty simple to implement, as we already support Connection(ssl=dict) :)

bujniewicz pushed a commit to bonnierpolska/celery that referenced this issue Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants