Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing docs about SQS long polling #665

Closed
thaddock opened this issue Nov 29, 2016 · 0 comments
Closed

Confusing docs about SQS long polling #665

thaddock opened this issue Nov 29, 2016 · 0 comments

Comments

@thaddock
Copy link
Contributor

It's confusing to tell if long polling is supported for SQS or not. It appears from the documentation and comments that it is not enabled, but looking at the code here:
https://github.com/celery/kombu/blob/master/kombu/transport/SQS.py#L335
and:
https://github.com/celery/kombu/blob/master/kombu/async/aws/sqs/connection.py#L79
it appears to be enabled with a default of 10 seconds.

If this is correct, the confusing comments should be updated.

thaddock pushed a commit to thaddock/kombu that referenced this issue Nov 29, 2016
auvipy pushed a commit that referenced this issue Nov 29, 2016
@auvipy auvipy closed this as completed Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants