New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0] Add newer Python 3 versions to build matrix #1111
[v3.0] Add newer Python 3 versions to build matrix #1111
Conversation
efd9deb
to
8162e75
Compare
6bacd26
to
7610f0d
Compare
For the `3.0` branch, add newer Python versions to the build matrix, up to Python 3.7. This is motivated by celery#1100, which backported a fix for the `3.0` branch to work with Python 3.7.
7610f0d
to
902a07c
Compare
@auvipy ping for awareness! With these changes to the Hopefully, this could allow us to have another 3.x release, compatible with newer Python versions :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop EOL py versions
I would gladly remove those versions! As it would be a breaking change for those Python versions, I wasn't sure of the approach you take on this project, as this commit will be tagged as minor/patch within the |
It's normal to drop the python version reaching EOL. we are not supposed to support celery 3.x as well but doing so for the sake of easier migration to 4.x versions. |
AppVeyor is now fixed by using almost the same configuration as |
can you update pypy2.7 to 7.2? |
I don't see |
I added it on celery master, check it |
I can add it to check if it works, but that environment didn't run for your PR: https://travis-ci.org/celery/celery/builds/601834152, and I don't see it running afterwards because it's in the |
I tested both
|
OK stick with 7.1.x |
So, I still don't know why the
My guess is that the PyPy installation provided by Travis is missing something, but I don't think it should block this PR from being merged. This pull request is now ready for review. After this one, I will check if migrating the test suite to PyTest makes any difference to fix that breaking environment. |
@auvipy, let me know if is there anything else I should add to this PR, to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. moving to pytest makes sense.
For the
3.0
branch, add newer Python versions to the build matrix, upto Python 3.7.
This is motivated by #1100, which backported a fix for the
3.0
branchto work with Python 3.7.