Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions CI #1309

Merged
merged 3 commits into from Mar 7, 2021
Merged

Add Github Actions CI #1309

merged 3 commits into from Mar 7, 2021

Conversation

matusvalo
Copy link
Member

@matusvalo matusvalo commented Mar 6, 2021 •
edited

This PR adds 1:1 support for GH Actions CI comparing to old Travis*. PR also removes requirement for librabbitmq in CI since it is not used directly by unittests/integration tests and introduced complexity to CI + building it was timeconsuming.

  • The only missing point is running unittests over pypy3 due failing unittests with complex errors (e.g. crasing in CAPI emulation layer of pypy)

- Implement CI is github actions

  • Skip failing pypy3 unittests
  • Added integration tests

@matusvalo
Copy link
Member Author

Note: Unittests are failing due #1308.

@matusvalo matusvalo requested review from thedrow and auvipy March 6, 2021 22:47
@matusvalo matusvalo self-assigned this Mar 6, 2021
@matusvalo matusvalo force-pushed the ci_matus branch 8 times, most recently from 898bbb8 to 5a83a24 Compare March 7, 2021 12:43
auvipy
auvipy approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. we can scrutinize later

@auvipy auvipy added this to In progress in Celery 5.1.0 via automation Mar 7, 2021
@auvipy auvipy merged commit 39ccacf into celery:master Mar 7, 2021
Celery 5.1.0 automation moved this from In progress to Done Mar 7, 2021
@matusvalo matusvalo deleted the ci_matus branch March 7, 2021 13:31
@matusvalo
Copy link
Member Author

Thank you @auvipy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@thedrow thedrow Awaiting requested review from thedrow

Assignees

@matusvalo matusvalo

Labels
Category: Packaging and Release Management Category: Tests Issue Type: Enhancement
Projects
No open projects
Celery 5.1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matusvalo @auvipy