Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow azurestoragequeues transport to be used with Azurite emulator in docker-compose #1611

Merged
merged 3 commits into from Oct 16, 2022

Conversation

davidbossanyi
Copy link
Contributor

When integration testing the azurestoragequeues transport locally using Azurite within a docker-compose stack, the queue url becomes http://<service>:10001/devstoreaccount1 rather than http://localhost:10001/devstoreaccount1 where <service> is the name of the azurite service in docker-compose. As described in this issue on the Azure python SDK, this results in a failure to connect to the queue service. This PR applies the suggested workaround in this comment to enable the kombu transport to work with Azurite in local docker-compose stacks for integration testing.

This PR should close #1168

davidbossanyi and others added 3 commits October 16, 2022 13:50
This more flexible credential allows the use of Azurite for integration testing in local docker-compose configurations.
@davidbossanyi
Copy link
Contributor Author

Seems like the pre-commit CI automatically changes union types from e.g. Union[dict, str] to the python 3.10 version dict | str which won't work for python < 3.10. Not sure what your preferred way to represent union types is? Let me know and I will alter as required.

@auvipy
Copy link
Member

auvipy commented Oct 16, 2022

import annotation from future let us use python 3.10 annotations in older version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Accept full range of azure storage queue connection parameters
2 participants