fix: handle keyerror in azureservicebus transport when message is not found in qos and perform basic_ack #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsmaelJS
changed the title
auvipy
requested changes
Apr 11, 2023
| try: | ||
| queue_obj.receiver.complete_message(delivery_info['azure_message']) | ||
| except azure.servicebus.exceptions.MessageAlreadySettled: | ||
| delivery_info = self.qos.get(delivery_tag).delivery_info |
There was a problem hiding this comment.
thanks for the PR! we need to verify this change with some unit tests
auvipy
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1661
When no_ack=True, the received message is not appended into qos, and thus KeyError is raised when trying to ack it.
This fix aims to handle that KeyError when trying to get the message from qos and perform the super basic_ack.