fix mongodb transport obsolete calls

[fmigneault]

changes

• replace obsolete collection remove by delete_one
• add test mock spec to check valid methods corresponding to the real objects
  (AttributeError raised if real class does not have this attribute/method)

tests

Validated with latest celery using celery inspect calls that were failing before this fix.

references

• fixes Broken MongoDB transport with pymongo>=4 #1689

[auvipy]

you used delete one and delete many, on theory they seem to be OK. but I'm not sure about the CI failures. can you please recheck?

[fmigneault]

The CI failures seems unrelated to the changes (failing dependency install of codecov).
I've successfully executed the test suite locally with pytest for everything related to mongodb.

[fmigneault]

you used delete one and delete many

In the case of delete matching by _id, it should be guaranteed to be unique.
Other deletes were comparing only against queue, which is not technically unique, hence the use of delete_many just in case.

[auvipy]

restarted the builld

[fmigneault]

Seems related to the following:
https://community.codecov.com/t/codecov-yanked-from-pypi-all-versions/4259

[auvipy]

uggh have to find out what to clean from the CI

[auvipy]

but pytest-cov should not be affected

[fmigneault]

pytest-cov works, it is only the coverage uploader that fails.
I use the following approach in multiple repositories: https://github.com/crim-ca/weaver/blob/master/.github/workflows/tests.yml#L134-L141

[auvipy]

can you please pull from main branch?

[auvipy]

thanks a lot