Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pytest v8 that removed nose compatibility #1914

Merged
merged 1 commit into from Feb 5, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 4, 2024

Fixes #1905

pytest v8 removes support for tests written for nose

Native pytest support uses setup_method and teardown_method [ ... ]
This is easy to do in an entire code base by doing a simple find/replace.

@cclauss cclauss marked this pull request as draft February 4, 2024 21:04
@Nusnus Nusnus self-requested a review February 4, 2024 21:15
@cclauss cclauss marked this pull request as ready for review February 4, 2024 21:37
@cclauss cclauss changed the title Upgrade to pytest v8 that remove nose compatibility Upgrade to pytest v8 that removed nose compatibility Feb 4, 2024
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nusnus Nusnus merged commit 10f5c3f into celery:main Feb 5, 2024
17 checks passed
@cclauss cclauss deleted the python-v8 branch February 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants